Mark YamlTemplate as GA #1531
Merged
Mark YamlTemplate as GA #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1531 +/- ##
============================================
+ Coverage 40.80% 40.93% +0.12%
- Complexity 2832 2833 +1
============================================
Files 743 742 -1
Lines 43166 43072 -94
Branches 4609 4596 -13
============================================
+ Hits 17615 17630 +15
+ Misses 24044 23937 -107
+ Partials 1507 1505 -2
|
Polber
force-pushed
the
jkinard/yaml-docs
branch
4 times, most recently
from
84517c9
to
a558465
Compare
damccorm
reviewed
May 7, 2024
| @@ -24,12 +24,21 @@ | |||
| name = "Yaml_Template", | |||
| category = TemplateCategory.GET_STARTED, | |||
| type = Template.TemplateType.YAML, | |||
| displayName = "YAML Template (Experimental)", | |||
| displayName = "YAML Template", | |||
There was a problem hiding this comment.
Can we avoid all the append logic by just making this YAML? Is there any reason not to do that?
There was a problem hiding this comment.
No, I just didn't like how it looked on the @Template tag, but idc that much - fixed.
Polber
force-pushed
the
jkinard/yaml-docs
branch
2 times, most recently
from
2a9ae57
to
9b17e29
Compare
Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
damccorm
added
the
Google LGTM
copybara-service
bot
merged commit b20548c
into
GoogleCloudPlatform:main
12 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.