Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import neo4j RM changes #1529

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Polber
Copy link
Contributor

@Polber Polber commented May 7, 2024

No description provided.

@Polber Polber marked this pull request as draft May 7, 2024 15:17
@Polber Polber force-pushed the jkinard/neo4j branch 2 times, most recently from 2130973 to 58881ea Compare May 10, 2024 16:13
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 66.92308% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 40.90%. Comparing base (6f82814) to head (6678a5f).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1529      +/-   ##
============================================
+ Coverage     40.80%   40.90%   +0.09%     
- Complexity     2832     2853      +21     
============================================
  Files           743      747       +4     
  Lines         43166    43313     +147     
  Branches       4609     4619      +10     
============================================
+ Hits          17615    17718     +103     
- Misses        24044    24088      +44     
  Partials       1507     1507              
Components Coverage Δ
spanner-templates 59.61% <ø> (+0.03%) ⬆️
spanner-import-export 64.47% <ø> (+0.08%) ⬆️
spanner-live-forward-migration 73.64% <ø> (ø)
spanner-live-reverse-replication 48.66% <ø> (ø)
spanner-bulk-migration 78.07% <ø> (ø)
Files Coverage Δ
...d/teleport/it/neo4j/Neo4jResourceManagerUtils.java 100.00% <100.00%> (ø)
.../cloud/teleport/it/neo4j/Neo4jResourceManager.java 90.69% <90.69%> (ø)
...e/cloud/teleport/it/neo4j/DatabaseWaitOptions.java 19.04% <19.04%> (ø)
.../teleport/it/neo4j/conditions/Neo4jQueryCheck.java 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
@Polber Polber self-assigned this May 22, 2024
@Polber Polber requested review from fbiville and an2x May 22, 2024 21:43
@Polber Polber marked this pull request as ready for review May 22, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants