Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JAVASCRIPT_UDF_FILE type to template parameter type #1528

Closed
wants to merge 3 commits into from

Conversation

Amar3tto
Copy link
Contributor

@Amar3tto Amar3tto commented May 7, 2024

No description provided.

@Amar3tto
Copy link
Contributor Author

Amar3tto commented May 7, 2024

R: @an2x

@liferoad liferoad requested a review from an2x May 9, 2024 14:25
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 40.95%. Comparing base (82dfb0b) to head (daec2f4).

Current head daec2f4 differs from pull request most recent head b7e5c3d

Please upload reports for the commit b7e5c3d to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1528      +/-   ##
============================================
+ Coverage     40.83%   40.95%   +0.11%     
+ Complexity     2834     2809      -25     
============================================
  Files           743      739       -4     
  Lines         43183    42872     -311     
  Branches       4610     4583      -27     
============================================
- Hits          17633    17557      -76     
+ Misses        24044    23815     -229     
+ Partials       1506     1500       -6     
Components Coverage Δ
spanner-templates 59.85% <ø> (+0.24%) ⬆️
spanner-import-export 65.59% <ø> (+1.13%) ⬆️
spanner-live-forward-migration 73.67% <ø> (+0.03%) ⬆️
spanner-live-reverse-replication 48.64% <ø> (-0.03%) ⬇️
spanner-bulk-migration 78.01% <ø> (-0.02%) ⬇️
Files Coverage Δ
...gle/cloud/teleport/metadata/TemplateParameter.java 0.00% <ø> (ø)
...le/cloud/teleport/metadata/util/MetadataUtils.java 41.42% <100.00%> (ø)
.../teleport/plugin/model/ImageSpecParameterType.java 100.00% <100.00%> (ø)
...eport/v2/transforms/JavascriptTextTransformer.java 75.35% <ø> (ø)
.../cloud/teleport/v2/templates/TextIOToBigQuery.java 68.00% <ø> (ø)
...loud/teleport/plugin/model/ImageSpecParameter.java 32.59% <85.71%> (ø)

... and 44 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant