Add scheduled dispatch workflows for test suites #1521
Conversation
Polber
force-pushed
the
jkinard/add-dispatch-workflows
branch
from
7911b5d
to
5000882
Compare
Polber
force-pushed
the
jkinard/add-dispatch-workflows
branch
from
5000882
to
c9fce62
Compare
Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
Polber
force-pushed
the
jkinard/add-dispatch-workflows
branch
from
c9fce62
to
47cece6
Compare
| - name: Setup Environment | ||
| id: setup-env | ||
| uses: ./.github/actions/setup-env | ||
|
|
||
| - name: Run Build | ||
| shell: bash | ||
| run: ./cicd/run-build --changed-files="${{ inputs.changed-files }}" |
There was a problem hiding this comment.
Should this just shell out to the run-build action?
There was a problem hiding this comment.
Same question applies elsewhere
| with: | ||
| ref: ${{ inputs.branch }} | ||
| fetch-depth: 2 # setup-env action assumes fetch depth of at least 2 for https://github.com/tj-actions/changed-files?tab=readme-ov-file#on-push-%EF%B8%8F | ||
| - name: Run Java Build |
There was a problem hiding this comment.
Having a build workflow seems less useful since this will be done by all the other workflows
|
|
||
| # Checks that are intended to run on PRs containing Java code. | ||
|
|
||
| name: Java Integration Tests |
There was a problem hiding this comment.
Taking a step back, what is your goal with these workflows? The Java PR workflow already can be run manually, why is having separate workflows better?
It seems like maybe the goal is to have a more granular signal? Or to allow individual pieces to be run independently of the main workflow?
I think there might be better ways to accomplish this - having 2 workflow files that do more or less the same thing is somewhat of an antipattern (and is just expensive). Rather than doing this, maybe we can restructure the existing java pr workflow to have some conditional logic. For example:
- Always run everything on schedule
- Run everything after build in parallel instead of serially
- Insert if conditions on the job that are basically like:
if: not is(workflow_dispatch) || input.run_its(similar to https://github.com/apache/beam/blob/ea3c2a4dbbe20a8e7161d362102bb1753bd60bba/.github/workflows/build_release_candidate.yml#L25)
There was a problem hiding this comment.
I'm generally supportive of moving things to composite actions where helpful, but I don't like doubling our workflow count, especially since we'd now need to do more work to keep different workflows in sync.
PR adds various workflows to be able to run individual test suite(s) against a branch, as well as run all the workflows on a 6 hour interval for observability.
This PR does not affect existing workflows - it only adds new ones.