Add GCS_READ_BUCKET type to the template parameter type

[akashorabek]

Add GCS_READ_BUCKET type to the template parameter type

[akashorabek]

R: @an2x

[codecov]

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 41.04%. Comparing base (45f4eb8) to head (64faa80).
Report is 99 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1513      +/-   ##
============================================
+ Coverage     40.93%   41.04%   +0.11%     
- Complexity     2815     2827      +12     
============================================
  Files           740      743       +3     
  Lines         42875    42979     +104     
  Branches       4585     4587       +2     
============================================
+ Hits          17549    17639      +90     
- Misses        23824    23838      +14     
  Partials       1502     1502              

Components	Coverage Δ
spanner-templates	60.02% <ø> (+0.21%)	⬆️
spanner-import-export	65.54% <ø> (-0.07%)	⬇️
spanner-live-forward-migration	73.64% <ø> (+0.06%)	⬆️
spanner-live-reverse-replication	48.66% <ø> (+0.15%)	⬆️
spanner-bulk-migration	78.03% <ø> (+0.34%)	⬆️

Files	Coverage Δ
...gle/cloud/teleport/metadata/TemplateParameter.java	0.00% <ø> (ø)
...le/cloud/teleport/metadata/util/MetadataUtils.java	41.42% <100.00%> (+1.72%)	⬆️
.../teleport/plugin/model/ImageSpecParameterType.java	100.00% <100.00%> (ø)
...loud/teleport/plugin/model/ImageSpecParameter.java	32.59% <85.71%> (+2.13%)	⬆️

... and 22 files with indirect coverage changes

[damccorm]

Just had one comment which applies across the board, otherwise this looks good. I'll hold off on reviewing similar PRs until that's addressed, I think we should be able to get them in pretty quickly at that point

[damccorm]

Could we please add a basic test like

DataflowTemplates/plugins/core-plugin/src/test/java/com/google/cloud/teleport/plugin/model/TemplateDefinitionsTest.java

Line 66 in abc502a

ImageSpecParameter inputKafkaTopic = metadata.getParameter("inputKafkaTopic").get();

?

[damccorm]

This applies to all of these PRs (cc @Amar3tto )

[Amar3tto]

Done (for all PRs)

[damccorm]

Thanks!