Modified dataflow templates parameter description #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…late" This reverts commit ad65fdd.
…bSub_to_MongoDB templates
...ud-to-googlecloud/src/main/java/com/google/cloud/teleport/v2/templates/TextIOToBigQuery.java
Outdated
Show resolved
Hide resolved
...ud-to-googlecloud/src/main/java/com/google/cloud/teleport/v2/templates/TextIOToBigQuery.java
Outdated
Show resolved
Hide resolved
v2/pubsub-to-mongodb/src/main/java/com/google/cloud/teleport/v2/templates/PubSubToMongoDB.java
Outdated
Show resolved
Hide resolved
v2/pubsub-to-mongodb/src/main/java/com/google/cloud/teleport/v2/templates/PubSubToMongoDB.java
Show resolved
Hide resolved
I think this is actually for the batch template? i.e. https://cloud.google.com/dataflow/docs/guides/templates/provided/cloud-storage-to-bigquery In the docs, the parameter descriptions are inconsistent between the streaming and batch versions of the template. But I don't think it matters which version we pick. |
...ud-to-googlecloud/src/main/java/com/google/cloud/teleport/v2/templates/TextIOToBigQuery.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1510 +/- ##
============================================
- Coverage 40.93% 40.18% -0.75%
+ Complexity 2815 2793 -22
============================================
Files 740 737 -3
Lines 42875 42768 -107
Branches 4585 4578 -7
============================================
- Hits 17549 17187 -362
- Misses 23824 24102 +278
+ Partials 1502 1479 -23
|
rszper
reviewed
May 6, 2024
...ud-to-googlecloud/src/main/java/com/google/cloud/teleport/v2/templates/TextIOToBigQuery.java
Outdated
Show resolved
Hide resolved
...ud-to-googlecloud/src/main/java/com/google/cloud/teleport/v2/templates/TextIOToBigQuery.java
Outdated
Show resolved
Hide resolved
...ud-to-googlecloud/src/main/java/com/google/cloud/teleport/v2/templates/TextIOToBigQuery.java
Outdated
Show resolved
Hide resolved
...ooglecloud/src/main/java/com/google/cloud/teleport/v2/templates/TextToBigQueryStreaming.java
Outdated
Show resolved
Hide resolved
v2/pubsub-to-mongodb/src/main/java/com/google/cloud/teleport/v2/templates/PubSubToMongoDB.java
Outdated
Show resolved
Hide resolved
v2/pubsub-to-mongodb/src/main/java/com/google/cloud/teleport/v2/templates/PubSubToMongoDB.java
Outdated
Show resolved
Hide resolved
v2/pubsub-to-mongodb/src/main/java/com/google/cloud/teleport/v2/templates/PubSubToMongoDB.java
Outdated
Show resolved
Hide resolved
v2/pubsub-to-mongodb/src/main/java/com/google/cloud/teleport/v2/templates/PubSubToMongoDB.java
Outdated
Show resolved
Hide resolved
changes suggested in descriptions Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
rszper
reviewed
May 7, 2024
...ud-to-googlecloud/src/main/java/com/google/cloud/teleport/v2/templates/TextIOToBigQuery.java
Outdated
Show resolved
Hide resolved
...ooglecloud/src/main/java/com/google/cloud/teleport/v2/templates/TextToBigQueryStreaming.java
Outdated
Show resolved
Hide resolved
rszper
reviewed
May 7, 2024
...ud-to-googlecloud/src/main/java/com/google/cloud/teleport/v2/templates/TextIOToBigQuery.java
Outdated
Show resolved
Hide resolved
...ud-to-googlecloud/src/main/java/com/google/cloud/teleport/v2/templates/TextIOToBigQuery.java
Outdated
Show resolved
Hide resolved
...ud-to-googlecloud/src/main/java/com/google/cloud/teleport/v2/templates/TextIOToBigQuery.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
rszper
approved these changes
May 13, 2024
v2/pubsub-to-mongodb/src/main/java/com/google/cloud/teleport/v2/templates/PubSubToMongoDB.java
Outdated
Show resolved
Hide resolved
…2/templates/PubSubToMongoDB.java Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
liferoad
added
the
Google LGTM
copybara-service
bot
merged commit 8dfb6de
into
GoogleCloudPlatform:main
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified parameters for Stream_GCS_Text_to_BigQuery_Flex and Cloud_PubSub_to_MongoDB templates