Modified parameters for Dataflow templates #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamannakakkar93
changed the title
tamannakakkar93
changed the title
tamannakakkar93
changed the title
tamannakakkar93
requested review from
manitgupta and
asthamohta
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1502 +/- ##
=========================================
Coverage 40.93% 40.93%
- Complexity 2808 2809 +1
=========================================
Files 739 739
Lines 42855 42855
Branches 4582 4582
=========================================
+ Hits 17542 17543 +1
Misses 23814 23814
+ Partials 1499 1498 -1
|
rszper
suggested changes
May 14, 2024
v1/src/main/java/com/google/cloud/teleport/templates/CSVToBigQuery.java
Outdated
Show resolved
Hide resolved
v1/src/main/java/com/google/cloud/teleport/templates/PubsubToAvro.java
Outdated
Show resolved
Hide resolved
v1/src/main/java/com/google/cloud/teleport/templates/PubsubToAvro.java
Outdated
Show resolved
Hide resolved
v1/src/main/java/com/google/cloud/teleport/templates/PubsubToAvro.java
Outdated
Show resolved
Hide resolved
v1/src/main/java/com/google/cloud/teleport/templates/PubsubToAvro.java
Outdated
Show resolved
Hide resolved
...c-to-googlecloud/src/main/java/com/google/cloud/teleport/v2/options/JdbcToPubsubOptions.java
Outdated
Show resolved
Hide resolved
...c-to-googlecloud/src/main/java/com/google/cloud/teleport/v2/options/JdbcToPubsubOptions.java
Outdated
Show resolved
Hide resolved
v2/kafka-to-bigquery/src/main/java/com/google/cloud/teleport/v2/templates/KafkaToBigQuery.java
Outdated
Show resolved
Hide resolved
...oud/src/main/java/com/google/cloud/teleport/v2/mongodb/options/MongoDbToBigQueryOptions.java
Outdated
Show resolved
Hide resolved
v2/pubsub-to-redis/src/main/java/com/google/cloud/teleport/v2/templates/PubSubToRedis.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
rszper
approved these changes
May 15, 2024
v1/src/main/java/com/google/cloud/teleport/bigtable/BigtableToJson.java
Outdated
Show resolved
Hide resolved
v1/src/main/java/com/google/cloud/teleport/templates/common/SpannerConverters.java
Outdated
Show resolved
Hide resolved
v1/src/main/java/com/google/cloud/teleport/templates/common/SpannerConverters.java
Outdated
Show resolved
Hide resolved
v1/src/main/java/com/google/cloud/teleport/templates/common/SpannerConverters.java
Outdated
Show resolved
Hide resolved
v2/common/src/main/java/com/google/cloud/teleport/v2/transforms/BigQueryConverters.java
Outdated
Show resolved
Hide resolved
v2/common/src/main/java/com/google/cloud/teleport/v2/transforms/BigQueryConverters.java
Outdated
Show resolved
Hide resolved
v2/common/src/main/java/com/google/cloud/teleport/v2/transforms/BigQueryConverters.java
Outdated
Show resolved
Hide resolved
.../main/java/com/google/cloud/teleport/v2/elasticsearch/options/ElasticsearchWriteOptions.java
Outdated
Show resolved
Hide resolved
v2/pubsub-to-redis/src/main/java/com/google/cloud/teleport/v2/templates/PubSubToRedis.java
Outdated
Show resolved
Hide resolved
…Json.java Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…annerConverters.java Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…s/BigQueryConverters.java Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…s/BigQueryConverters.java Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…s/BigQueryConverters.java Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…t/v2/elasticsearch/options/ElasticsearchWriteOptions.java Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…templates/PubSubToRedis.java Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…annerConverters.java Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…annerConverters.java Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
rszper
approved these changes
May 16, 2024
.../main/java/com/google/cloud/teleport/v2/elasticsearch/options/ElasticsearchWriteOptions.java
Outdated
Show resolved
Hide resolved
…t/v2/elasticsearch/options/ElasticsearchWriteOptions.java Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
damccorm
approved these changes
May 20, 2024
damccorm
added
the
Google LGTM
copybara-service
bot
merged commit 1acbde8
into
GoogleCloudPlatform:main
11 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.