Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spark-rapids] Update spark rapids version to 24.04.0 #1176

Conversation

SurajAralihalli
Copy link
Contributor

@SurajAralihalli SurajAralihalli commented Apr 23, 2024

This PR updates

  1. spark-rapids.sh init script with the latest 24.02.0 (to-date) rapids-4-spark version.
  2. Changes default driver version to 550.54.15 and cuda 12.4.1
  3. Uses apt-get --allow-releaseinfo-change update to unblock downstream applications until dataproc platform fixes apt-get update issues in Debian 10 and Ubuntu linux distros.

signed-off-by: Suraj Aralihalli suraj.ara16@gmail.com

Signed-off-by: Suraj Aralihalli <suraj.ara16@gmail.com>
@SurajAralihalli
Copy link
Contributor Author

FYI @viadea @jayadeep-jayaraman

@jayadeep-jayaraman
Copy link
Collaborator

/gcbrun

Signed-off-by: Suraj Aralihalli <suraj.ara16@gmail.com>
Signed-off-by: Suraj Aralihalli <suraj.ara16@gmail.com>
Signed-off-by: Suraj Aralihalli <suraj.ara16@gmail.com>
@jayadeep-jayaraman
Copy link
Collaborator

/gcbrun

@jayadeep-jayaraman
Copy link
Collaborator

+ echo 'Error: Secure Boot is enabled. Please disable Secure Boot while creating the cluster.'
Error: Secure Boot is enabled. Please disable Secure Boot while creating the cluster.
+ exit 1

We need to disable secure-boot for 2.2 ubuntu

@viadea
Copy link
Contributor

viadea commented May 20, 2024

+ echo 'Error: Secure Boot is enabled. Please disable Secure Boot while creating the cluster.'
Error: Secure Boot is enabled. Please disable Secure Boot while creating the cluster.
+ exit 1

We need to disable secure-boot for 2.2 ubuntu

@jayadeep-jayaraman Is there any action item needed in this PR?
I think this error just tells us we need to disable secure boot for 2.1 and 2.2 dataproc in your CICD pipeline.

@SurajAralihalli
Copy link
Contributor Author

We need to disable secure-boot for 2.2 ubuntu

Yes we need to disable secure boot for Dataproc 2.1 and 2.2 to install the drivers. A note to disable secure boot is added in the Create a Dataproc cluster accelerated by gpus docs for users.

@jayadeep-jayaraman
Copy link
Collaborator

The test is failing for 2.2 ubuntu and we should bypass the test for this image version in the PR

@viadea
Copy link
Contributor

viadea commented May 20, 2024

The test is failing for 2.2 ubuntu and we should bypass the test for this image version in the PR

@jayadeep-jayaraman i do not think we can run the CICD test to confirm. Do you want to fix this in this PR or you want us to fix this?

@SurajAralihalli
Copy link
Contributor Author

SurajAralihalli commented May 20, 2024

The test is failing for 2.2 ubuntu and we should bypass the test for this image version in the PR

Secure boot needs to be disabled for ubuntu 22. Would you recommend bypass this check however I think this check will be useful to the users to identify the issue when secure boot is enabled.

Signed-off-by: Suraj Aralihalli <suraj.ara16@gmail.com>
Signed-off-by: Suraj Aralihalli <suraj.ara16@gmail.com>
@SurajAralihalli
Copy link
Contributor Author

@jayadeep-jayaraman @viadea @sameerz
I've updated the PR to run the skip the tests on 2.0 and 2.1 (due to secure boot issue). I'm confident that the tests would succeed if we find a way to disable the secure boot in CI. This means the tests would run only on Debian 10 (2.0) as we are in the processing of dropping support for Ubuntu 18. To unblock the PR from being merged asap I've included --allow-releaseinfo-change.

@viadea
Copy link
Contributor

viadea commented May 21, 2024

@jayadeep-jayaraman @viadea @sameerz I've updated the PR to run the skip the tests on 2.0 and 2.1 (due to secure boot issue). I'm confident that the tests would succeed if we find a way to disable the secure boot in CI. This means the tests would run only on Debian 10 (2.0) as we are in the processing of dropping support for Ubuntu 18. To unblock the PR from being merged asap I've included --allow-releaseinfo-change.

LGTM. @jayadeep-jayaraman shall we merge it after test is passed?

@jayadeep-jayaraman
Copy link
Collaborator

/gcbrun

@jayadeep-jayaraman jayadeep-jayaraman merged commit ddc335b into GoogleCloudDataproc:master May 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants