Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node manager failure during script execution #1047

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jster1357
Copy link
Contributor

current script fails. This fixes the issue where the node manager doesn't restart due to the insertion of new settings while the node manager is running.

current script fails. This fixes the issue where the node manager doesn't restart due to the insertion of new settings while the node manager is running.
@jster1357 jster1357 changed the title Update prometheus.sh Fix node manager failure during script execution Feb 8, 2023
Copy link
Contributor

@Arun-Krishna Arun-Krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the issue related to restart not picking up the conf changes?

Comment on lines 148 to 150
else
stop_service_gracefully hadoop-yarn-nodemanager.service
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the indentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is done

Comment on lines 168 to 170
else
restart_service_gracefully hadoop-yarn-nodemanager.service
start_service_gracefully hadoop-yarn-nodemanager.service
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the indentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is done

adjusted indententions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants