shouldInlineFonts if fonts or inlineFonts = true

[newsroomdev]

Description of changes

This change updates shouldInlineFonts to evaluate as described in the README: true if either the fonts or inlineFonts option is set to true. At the moment, both fonts and inlineFonts would need to be set to true for the whole statement to be truthy.

• inlineFonts Boolean Inline critical font-face rules (default: false)
• preloadFonts Boolean Preloads critical fonts (default: true)
• fonts Boolean Shorthand for setting inlineFonts+preloadFonts- Values:
  • true to inline critical font-face rules and preload the fonts
  • false to don't inline any font-face rules and don't preload fonts

@developit

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[newsroomdev]

@googlebot I signed it!

[newsroomdev]

cc @developit

[developit]

Hiya - sorry for taking a bit to get around to this. I'm not entirely sure what the best option is for this, since the property is currently a tri-state:

• fonts: false: don't inline or preload anything
• fonts: true: inline and preload everything
• fonts: undefined: preload, but don't inline (this is the default)

[janicklas-ralph]

This could be a breaking change since users might be expecting a certain behavior.

Maybe we can rethink the fonts flag? Remove it given the confusion and also the additional font optimization (WIP) makes it less extensible.

[developit]

Removing it seems like the way to go.