New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(yargs): upgrade to 17.3.1 #13590
Merged
Merged
Changes from 17 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
4798796
update
connorjclark 5d1f2ca
go back to being nully
connorjclark 544e0cb
update types
connorjclark c4e8df4
tweak
connorjclark 3cd1441
tweak extraHeaders coerce
connorjclark c23ea16
comments
connorjclark 977d400
Merge remote-tracking branch 'origin/master' into update-yargs
connorjclark 2324848
tests: add snapshot tests for cli-flags.js
connorjclark e076404
normalize
connorjclark 994c974
slashes
connorjclark a3e1a71
Merge remote-tracking branch 'origin/flags-snapshots' into update-yargs
connorjclark 90a07d1
update
connorjclark d288da1
update
connorjclark a5ce390
g
connorjclark f5c3d50
Merge remote-tracking branch 'origin/flags-snapshots' into update-yargs
connorjclark c529920
Merge remote-tracking branch 'origin/master' into update-yargs
connorjclark 80ed3e7
snap
connorjclark 64fce54
dont need those
connorjclark c539e48
Merge remote-tracking branch 'origin/master' into update-yargs
connorjclark 08878c0
tweak
connorjclark 5c35f44
update
connorjclark File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -388,6 +388,49 @@ Object { | |
} | ||
`; | ||
|
||
exports[`CLI flags settings are accepted from a file path (inlined budgets) 1`] = ` | ||
Object { | ||
"$0": "node_modules/jest/bin/jest.js", | ||
"_": Array [ | ||
"http://www.example.com", | ||
], | ||
"budgets": Array [ | ||
Object { | ||
"anything": "works", | ||
}, | ||
], | ||
"channel": "cli", | ||
"chrome-flags": "", | ||
"chrome-ignore-default-flags": false, | ||
"chromeFlags": "", | ||
"chromeIgnoreDefaultFlags": false, | ||
"cli-flags-path": "__REPLACED__/lighthouse-cli/test/fixtures/cli-flags-path-inline-budgets.json", | ||
"cliFlagsPath": "__REPLACED__/lighthouse-cli/test/fixtures/cli-flags-path-inline-budgets.json", | ||
"enable-error-reporting": undefined, | ||
"enableErrorReporting": undefined, | ||
"fraggle-rock": false, | ||
"fraggleRock": false, | ||
"hostname": "127.0.0.1", | ||
"list-all-audits": false, | ||
"list-locales": false, | ||
"list-trace-categories": false, | ||
"listAllAudits": false, | ||
"listLocales": false, | ||
"listTraceCategories": false, | ||
"output": Array [ | ||
"html", | ||
], | ||
"port": 0, | ||
"print-config": false, | ||
"printConfig": false, | ||
"quiet": false, | ||
"save-assets": false, | ||
"saveAssets": false, | ||
"verbose": false, | ||
"view": false, | ||
} | ||
`; | ||
|
||
exports[`CLI flags settings are accepted from a file path 1`] = ` | ||
Object { | ||
"$0": "node_modules/jest/bin/jest.js", | ||
|
@@ -413,9 +456,6 @@ Object { | |
"extraHeaders": Object { | ||
"X-Men": "wolverine", | ||
}, | ||
"extraheaders": Object { | ||
"xMen": "wolverine", | ||
}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. seems the older yargs was overzealous in how it interprets provided config files. |
||
"fraggle-rock": false, | ||
"fraggleRock": false, | ||
"hostname": "127.0.0.1", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
lighthouse-cli/test/fixtures/cli-flags-path-inline-budgets.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"budgets": [{"anything": "works"}] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests for the special handling of this flag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the snapshot tests tho. I don't understand the comment in this flag's options anyway, @brendankenny may know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm seems like it isn't necessary https://github.com/GoogleChrome/lighthouse/pull/11794/files#r539003671