Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug) Non-Error promise rejection captured with keys: currentTarget, isTrusted, target, type #2851

Merged
merged 11 commits into from
Jan 3, 2021

Conversation

MarianoAmado
Copy link
Contributor

Description

Fix Sentry Non-Error promise rejection error: passing Error obj to rej() instead of Event obj in deleteGunDB() function
Comment on a related issue: getsentry/sentry-javascript#2546 (comment)

About #2830

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • PR title matches follow: (Feature|Bug|Chore) Task Name
  • My code follows the style guidelines of this project
  • I have followed all the instructions described in the initial task (check Definitions of Done)
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added reference to a related issue in the repository
  • I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
  • I have added screenshots related to my pull request (for frontend tasks)
  • I have pasted a gif showing the feature.
  • @mentions of the person or team responsible for reviewing proposed changes

…j() instead of Event obj

(in deleteGunDB() function)
@MarianoAmado
Copy link
Contributor Author

@sirpy @serdiukov-o-nordwhale
Please check the message passed to the Error obj

@serdiukov-o-nordwhale
Copy link
Contributor

@MarianoAmado i've adjusted the code according to the IndexedDB API docs.
please re-check how it's working now and how exception is caught and reported now

@sirpy sirpy merged commit 2336a3b into master Jan 3, 2021
@sirpy sirpy deleted the 2830-non-error-promise-rej-sentry branch January 3, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants