Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-Error promise rejection captured with keys: currentTarget, isTrusted, target, type #2830

Closed
sentry-io bot opened this issue Dec 22, 2020 · 7 comments
Assignees
Labels

Comments

@sentry-io
Copy link

sentry-io bot commented Dec 22, 2020

Sentry Issue: GOODDAPP-4X

Event: Non-Error promise rejection captured with keys: currentTarget, isTrusted, target, type
@MarianoAmado
Copy link
Contributor

MarianoAmado commented Dec 28, 2020

@serdiukov-o-nordwhale @sirpy
This error shows that we are rejecting a Promise by passing an Event object to the reject() function instead of an Error object as expected by sentry.

This seems to be happening in deleteGunDB() in lib/hooks/useDeleteAccountDialog.js (Ln 28):
image.png
where we do objectStoreRequest.onerror = rej, because onerror is passing an Event obj to rej()
The solution would be something like:
objectStoreRequest.onerror = e => rej(new Error('Error message'))

Here's an explanation of a similar issue getsentry/sentry-javascript#2546 (comment)

@omerzam
Copy link
Contributor

omerzam commented Mar 24, 2021

@serdiukov-o-nordwhale is this still reproducing?

@serdiukov-o-nordwhale
Copy link
Contributor

@omerzam During bugs review ~moth ago we've found that yes
So we'll back to this issue once we'll have time for that

@lenkaborshch
Copy link

@serdiukov-o-nordwhale Did you manage to solve this problem?

@serdiukov-o-nordwhale
Copy link
Contributor

@lenkaborshch not yet, it's not a priority for now

@johnsmith-gooddollar
Copy link
Collaborator

@vldkh does it still reproduces ?
@roma-hladilka take a quick look if yes

@vldkhh vldkhh assigned vldkhh and unassigned vldkh Jul 13, 2022
@vldkhh
Copy link

vldkhh commented Jul 14, 2022

@johnsmith-gooddollar looks like fixed
image.png

@vldkhh vldkhh closed this as completed Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests