Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release_debug target #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

lyuma
Copy link
Contributor

@lyuma lyuma commented Jun 19, 2020

No description provided.

@BastiaanOlij
Copy link
Member

I've never really understood the need for both release debug and debug, I would just add the switch to debug, it's always supposed to have the debug symbols, actually surprised we got that switch wrong.

Note: other platforms already implement release_debug by providing debug symbols with -g on release builds.
@lyuma lyuma changed the title Add release_debug target; add debug symbols to debug target. Add release_debug target Jul 31, 2020
@lyuma
Copy link
Contributor Author

lyuma commented Jul 31, 2020

I have split off the bugfix for debug symbols in the debug target, into #102 -- However, I think this PR is still relevant.

The use-case for a release_debug target is to build for release, while also generating a .pdb file which could be used for debugging crash reports sent by users.

There are some good arguments to be made here: https://stackoverflow.com/a/5457250

I will say, CI systems are often linux-based and will hit the use_llvm=yes case, which does already generate debug symbols on release. So the value of this PR is minimal in practice.

It may also make sense to just change the release to generate the .pdb file, to match the behavior of other platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants