Fix implementation of Player.getVirtualHost()/getProtocolVersion() #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, Player.getVirtualHost() returns the client's IP address. However, it is actually supposed to return the hostname/port the player used to connect to the server. Correct this and also make use of the version information in GlowSession instead of just returning the constant.
|
|
|
Does this fix #547? |
aramperes
approved these changes
Jan 28, 2018
|
@mastercoms Not sure, it's not too likely that many public plugins are already using this API (considering it is Paper only) - so probably not. |
Pr0methean
approved these changes
Jan 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now,
Player.getVirtualHost()returns the client's IP address. However, it is actually supposed to return the hostname/port the player used to connect to the server.Correct this and also make use of the version information in GlowSession instead of just returning the constant.
For reference: API was added in PaperMC/Paper#914