[WIP] Adds Full 1.12 /fill Command Support #1052
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aramperes
requested changes
Aug 13, 2019
| int placementMode = 0; | ||
| if (args.length > 8) { | ||
| if (args[8].equalsIgnoreCase("outline")) { | ||
| placementMode = 1; |
There was a problem hiding this comment.
Replace these magic values with an enum, then have a lookup table to convert the command argument to enum values.
| double placeX; | ||
| double placeY; | ||
| double placeZ; | ||
| if (x1 > x2) { |
There was a problem hiding this comment.
All of these can be replaced using Math.max() and Math.min(), used at the declaration of each variable.
| } | ||
| } | ||
| } | ||
| xmin += 1; |
There was a problem hiding this comment.
Use ++ and -- instead.
Although I'm starting to think this could make use/extend the BoundingBox utilities somehow. Maybe using this method?
| return Collections.emptyList(); | ||
| } | ||
|
|
||
| public boolean placeBlock(Location location, byte dataValue, String[] args, Material type, CommandMessages commandMessages, CommandSender sender, int placementMode) { |
There was a problem hiding this comment.
If this method needs to be public, it needs Javadocs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fully implements the 1.12 vanilla /fill command. The code may need some clean-up.
Related to #499