This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
General changes pulled from the Bukkit repository #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, it was not possible to modify the iron golem's flower holding ability. This commit changes that.
Previously it was not possible to determine when an entity despawns for reasons other than death. This made it difficult for plugins to determine things like despawning due to distance or other causes, and therefore may still track those now-missing entities. This commit allows plugin authors to determine what happened to entities when they despawn for their various reasons, therefore making plugin developer's lives a little bit easier.
Previously, FoodLevelChangeEvent only provided the player involved in the event and the new food level of the player. This changes the event to also provide the type of food being consumed, along with the new saturation and exhaustion levels of the player.
Plugin developers may require modifying how an arrow reacts to a player trying to pick it up (such as ensuring that arrows fired by skeletons can be picked up normally). This was not possible prior to this commit.
Previously it was not possible to determine when, for example, a skeleton picked up and equipped a helmet. This is a fairly important feature for plugins that need to manage entities to ensure balancing in concepts such as minigames. This commit resolves the issue by adding the event required to determine when entities equip items.
Previously it was not possible to change where the player spawned upon leaving a bed. This commit changes that.
Previously it was not possible to determine when an entity was saddled. This commit changes that by adding the applicable event for the action.
Previously it was not possible to determine when brewing has ended or what potions were involved in a brew event. These are required for plugins to fully deal with brewing in Bukkit. This commit adds the capability to have that support.
The BlockDispenseEvent is missing a method to get the slot that an item was dispensed from. Without this commit, there is no way to find out which slot an item was dispensed from, preventing exact rollbacks of changes to a dispenser. This commit fixes the issue by adding the getSlot method to the BlockDispenseEvent.
Previously it was not possible to determine why a non-player entity has teleported. This commit changes that so plugins are able to determine what has happened.
Previously only sheep were handled for being dyed. However, currently there are other mobs that can be dyed by the player, such as wolves. This commit adds the event required for detecting those changes as well as manipulates the existing event to be deprecated and implement this new event.
Changes made: 1051 - Documentation and naming 1039 - Documentation 777 - Documentation 840 - Add player to event 765 - Documentation
|
Huh, considering Bukkit has kinda fallen I might actually finish that. Funny how it works that way I guess. I should still have that bit of code somewhere if my online repo is DCMA'd so I'll see what I can do there for mine. I'd imagine in terms of implementation the CraftBukkit side would have to be redone, correct? |
|
Yes, the implementation side for all these would need to be redone for Glowstone instead. Of course, many of them don't yet have places in Glowstone where they could be implemented yet, since the corresponding feature isn't implemented. |
Closed
This was referenced Oct 20, 2014
|
Closing this PR as the commits have been split up over several other PRs. Please see the now-edited description for the PR links (or traverse the github spam above). Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes shouldn't break glowstone if pulled, but should be implemented as required. This PR is simply opened as a reminder to myself that these changes exist until pulled.
Credit to:
Bukkit #1070New PR: GlowstoneMC/Glowkit#36Bukkit #765New PR: GlowstoneMC/Glowkit#42Bukkit #1051New PR: GlowstoneMC/Glowkit#43Bukkit #777New PR: GlowstoneMC/Glowkit#44Bukkit #785New PR: GlowstoneMC/Glowkit#37Bukkit #840New PR: GlowstoneMC/Glowkit#45Bukkit #873New PR: GlowstoneMC/Glowkit#38Bukkit #1022New PR: GlowstoneMC/Glowkit#39Bukkit #1002New PR: GlowstoneMC/Glowkit#40Bukkit #1039New PR: GlowstoneMC/Glowkit#46Bukkit #827New PR: GlowstoneMC/Glowkit#41Thank you to everyone who has contributed. Sorry if you PR wasn't pulled in Bukkit :(
Contributors: