Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Android TV remote service #2004

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

bertrandda
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

Add Android TV service to control smart TV

Copy link

relativeci bot commented Jan 18, 2024

Job #2273: Bundle Size — 9.68MiB (+0.46%).

6ab3d5a(current) vs 49c8237 master#2256(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Regression 1 regression
                 Current
Job #2273
     Baseline
Job #2256
Regression  Initial JS 5.26MiB(+0.53%) 5.23MiB
No change  Initial CSS 302.56KiB 302.56KiB
Change  Cache Invalidation 54.92% 0%
No change  Chunks 51 51
Change  Assets 162(+0.62%) 161
Change  Modules 1442(+0.42%) 1436
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.8% 0.8%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 3 changes Regression 3 regressions
                 Current
Job #2273
     Baseline
Job #2256
Regression  JS 6.95MiB (+0.4%) 6.92MiB
Regression  IMG 2.3MiB (+0.73%) 2.28MiB
Not changed  CSS 319.07KiB 319.07KiB
Not changed  Fonts 93.55KiB 93.55KiB
Regression  Other 16.59KiB (+0.53%) 16.5KiB
Not changed  HTML 13.58KiB 13.58KiB

View job #2273 reportView bertrandda:feat/android-tv-remot... branch activityView project dashboard

Copy link

stale bot commented Mar 22, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 22, 2024
@bertrandda bertrandda changed the title Android TV remote service [WIP] Android TV remote service Mar 26, 2024
@stale stale bot removed the stale label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant