Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecovacs #1712

Open
wants to merge 157 commits into
base: master
Choose a base branch
from
Open

Ecovacs #1712

wants to merge 157 commits into from

Conversation

ngeissel
Copy link
Contributor

@ngeissel ngeissel commented Feb 19, 2023

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add Ecovacs service that allows to add vacbots in Gladys. It handles basic commands as : clean, pause, stop, return to charge station. It returns : batery level and clean reports. It also add to gladys a brand new vacbot box (regrouping all main function in only one box).
More information here :https://github.com/ngeissel/Gladys/tree/ecovacs/server/services/ecovacs.
ecovacs_screenshot

@VonOx
Copy link
Contributor

VonOx commented Feb 22, 2023

@ngeissel if you need functional test, I've ecovacs deebot.

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Attention: Patch coverage is 99.28315% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 98.42%. Comparing base (09a7987) to head (f55117f).

Current head f55117f differs from pull request most recent head 44dede8

Please upload reports for the commit 44dede8 to get more accurate results.

Files Patch % Lines
...ver/services/ecovacs/lib/device/vacbot.setValue.js 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1712      +/-   ##
==========================================
+ Coverage   98.40%   98.42%   +0.01%     
==========================================
  Files         858      879      +21     
  Lines       14081    14317     +236     
==========================================
+ Hits        13857    14091     +234     
- Misses        224      226       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngeissel ngeissel changed the title [WIP] Ecovacs Ecovacs Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants