Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rflink with tests #1204

Open
wants to merge 306 commits into
base: master
Choose a base branch
from
Open

Rflink with tests #1204

wants to merge 306 commits into from

Conversation

ngeissel
Copy link
Contributor

@ngeissel ngeissel commented May 26, 2021

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@stale
Copy link

stale bot commented Aug 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 21, 2023
@stale stale bot removed the stale label Aug 25, 2023
@relativeci
Copy link

relativeci bot commented Sep 13, 2023

#2578 Bundle Size — 10.34MiB (+2%).

04b4aa4(current) vs 09a7987 master#2576(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 6 changes Regression 2 regressions
                 Current
#2578
     Baseline
#2576
Regression  Initial JS 5.55MiB(+1.67%) 5.46MiB
Regression  Initial CSS 302.98KiB(~+0.01%) 302.96KiB
Change  Cache Invalidation 60.48% 63.14%
No change  Chunks 51 51
Change  Assets 171(+0.59%) 170
Change  Modules 1494(+0.95%) 1480
No change  Duplicate Modules 21 21
Change  Duplicate Code 0.81%(-1.22%) 0.82%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 4 changes Regression 4 regressions
                 Current
#2578
     Baseline
#2576
Regression  JS 7.33MiB (+1.3%) 7.24MiB
Regression  IMG 2.57MiB (+4.4%) 2.46MiB
Regression  CSS 319.77KiB (~+0.01%) 319.75KiB
No change  Fonts 93.55KiB 93.55KiB
Regression  Other 17.61KiB (+0.46%) 17.53KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch ngeissel:rflinkProject dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants