Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Raster.dtypes tuple to a Raster.dtype string #528

Merged
merged 5 commits into from Mar 28, 2024

Conversation

rhugonnet
Copy link
Contributor

Having dtypes as a tuple is effectively never used, even in Rasterio if I'm not mistaken, like for nodata.

Having a single value makes things much more straightforward for the user (and us).

Resolves #520

@rhugonnet rhugonnet merged commit ae96994 into GlacioHack:main Mar 28, 2024
13 checks passed
@rhugonnet rhugonnet deleted the refactor_dtypes branch March 28, 2024 00:56
Copy link
Member

@adehecq adehecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright !
I've never encountered rasters with multiple bands that had different dtypes... I guess if a multiple dtypes functionality is added in rasterio in the future, we'll just have to reverse this PR 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove iterable Raster.dtypes into a single dtype attribute
2 participants