Bugfix/exc when changing repo #621
Open
+1
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason for changes Changing a route on RepoTile tap is causing the following error: > Looking up a deactivated widget's ancestor is unsafe. The exception is caused by an attempt to use already defunct context. The context has been destroyed during the repo change a line before. Effectively, the removed do not do anything since the entire app is rebuild using GitJournalChangeNotifier and doesn't change a route by the navigator. What changed? Removed lines that caused errors and had no effect.
mnowotnik
force-pushed
the
bugfix/exc-when-changing-repo
branch
from
6324030
to
f02c32a
Compare
|
Sorry. I seem to have missed these. If I don't respond in 24 hours, please feel free to ping me. |
|
@vHanda pinging, please check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for changes
Changing a route on RepoTile tap is causing the following error:
The exception is caused by an attempt to use already defunct context.
The context has been destroyed during the repo change a line before.
Effectively, the removed lines do not do anything since the entire
app is rebuilt using GitJournalChangeNotifier and doesn't change a route
by the navigator.
What changed?
Removed lines that caused errors and had no effect.
Testing and Review Notes
Change repository in the draw while in dev mode. Look at the console log.