Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling #104

Merged
merged 1 commit into from
May 17, 2024
Merged

Improve error handling #104

merged 1 commit into from
May 17, 2024

Conversation

agateau-gg
Copy link
Collaborator

This PR improves how we handle server responses by not assuming it is going to include a Content-Type header. This makes GGClient more robust in contexts where network responses are generated by tools like firewalls.

Do not crash if the server response is not JSON.
@agateau-gg agateau-gg requested a review from fnareoh May 14, 2024 12:48
@agateau-gg agateau-gg merged commit 160b2a8 into master May 17, 2024
19 checks passed
@agateau-gg agateau-gg deleted the agateau/improve-error-handling branch May 17, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants