Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility for python 3.12 #1632

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

Hartorn
Copy link
Member

@Hartorn Hartorn commented Nov 23, 2023

Description

Related Issue

Type of Change

  • 馃摎 Examples / docs / tutorials / dependencies update
  • 馃敡 Bug fix (non-breaking change which fixes an issue)
  • 馃 Improvement (non-breaking change which improves an existing feature)
  • 馃殌 New feature (non-breaking change which adds functionality)
  • 馃挜 Breaking change (fix or feature that would cause existing functionality to change)
  • 馃攼 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@Hartorn Hartorn added the Lockfile Temporary label to update pdm.lock label Nov 23, 2023
@Hartorn Hartorn requested a review from mattbit November 23, 2023 11:43
@Hartorn Hartorn self-assigned this Nov 23, 2023
@github-actions github-actions bot removed the Lockfile Temporary label to update pdm.lock label Nov 23, 2023
@mattbit
Copy link
Member

mattbit commented Nov 23, 2023

@Hartorn this seems to work great with vanilla giskard, but not when we use the optional group llm

@Hartorn Hartorn added the Lockfile Temporary label to update pdm.lock label Nov 23, 2023
@github-actions github-actions bot removed the Lockfile Temporary label to update pdm.lock label Nov 23, 2023
@Hartorn
Copy link
Member Author

Hartorn commented Nov 23, 2023

@Hartorn this seems to work great with vanilla giskard, but not when we use the optional group llm

I'm looking at it, but I think torch stable is not yet supporting 3.12, so bert score wont be working.
Trying to switch on nightly from torch

@Hartorn
Copy link
Member Author

Hartorn commented Nov 23, 2023

Also, https://github.com/pytorch/text pytorch-text depends on specific torch version 2.1.1
Will not work for python 3.12 I think

@Hartorn
Copy link
Member Author

Hartorn commented Nov 23, 2023

should be arriving soon on stable : pytorch/pytorch#110436

@Hartorn Hartorn added the Lockfile Temporary label to update pdm.lock label Nov 23, 2023
@github-actions github-actions bot removed the Lockfile Temporary label to update pdm.lock label Nov 23, 2023
@Hartorn Hartorn added the Lockfile Temporary label to update pdm.lock label Nov 23, 2023
@github-actions github-actions bot removed the Lockfile Temporary label to update pdm.lock label Nov 23, 2023
Copy link

sonarcloud bot commented Nov 23, 2023

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@andreybavt andreybavt added the Lockfile Temporary label to update pdm.lock label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lockfile Temporary label to update pdm.lock on hold
Development

Successfully merging this pull request may close these issues.

None yet

3 participants