Finance: fix SQL state error in Add Invoice and Edit Invoice

GibbonEdu · Jan 20, 2022 · 62d2298 · 62d2298
1 parent 477652f
commit 62d2298
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/modules/Finance/invoices_manage_add.php b/modules/Finance/invoices_manage_add.php
@@ -145,7 +145,7 @@
 
         // Add predefined block data (for templating new blocks, triggered with the feeSelector)
         $data = array('gibbonSchoolYearID' => $gibbonSchoolYearID);
-        $sql = "SELECT gibbonFinanceFeeID as groupBy, gibbonFinanceFeeID, name, description, fee, gibbonFinanceFeeCategoryID FROM gibbonFinanceFee ORDER BY name";
+        $sql = "SELECT gibbonFinanceFeeID as groupBy, gibbonFinanceFeeID, name, description, fee, gibbonFinanceFeeCategoryID FROM gibbonFinanceFee WHERE gibbonSchoolYearID=:gibbonSchoolYearID ORDER BY name";
         $result = $pdo->executeQuery($data, $sql);
         $feeData = $result->rowCount() > 0? $result->fetchAll(\PDO::FETCH_GROUP|\PDO::FETCH_UNIQUE) : array();
 

diff --git a/modules/Finance/invoices_manage_edit.php b/modules/Finance/invoices_manage_edit.php
@@ -220,7 +220,7 @@
 
                 // Add predefined block data (for templating new blocks, triggered with the feeSelector)
                 $data = array('gibbonSchoolYearID' => $gibbonSchoolYearID);
-                $sql = "SELECT gibbonFinanceFeeID as groupBy, gibbonFinanceFeeID, name, description, fee, gibbonFinanceFeeCategoryID FROM gibbonFinanceFee ORDER BY name";
+                $sql = "SELECT gibbonFinanceFeeID as groupBy, gibbonFinanceFeeID, name, description, fee, gibbonFinanceFeeCategoryID FROM gibbonFinanceFee WHERE gibbonSchoolYearID=:gibbonSchoolYearID  ORDER BY name";
                 $result = $pdo->executeQuery($data, $sql);
                 $feeData = $result->rowCount() > 0? $result->fetchAll(\PDO::FETCH_GROUP|\PDO::FETCH_UNIQUE) : array();