-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 💥 new environment and volume var naming #1729
Draft
nemchik
wants to merge
26
commits into
master
Choose a base branch
from
variable-naming
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+2,230
−2,862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ci
Automatic label
apps
Automatic label
docs
Automatic label
core
Automatic label
repo
Automatic label
labels
Feb 19, 2024
nemchik
force-pushed
the
variable-naming
branch
4 times, most recently
from
February 19, 2024 03:13
1e4f054
to
76dc44d
Compare
Signed-off-by: Eric Nemchik <eric@nemchik.com>
nemchik
force-pushed
the
variable-naming
branch
from
February 19, 2024 03:21
76dc44d
to
a829ea2
Compare
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Signed-off-by: Eric Nemchik <eric@nemchik.com>
This was referenced Feb 20, 2024
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Fix `PLEX_ENVIRONMENT_CLAIM` TO `PLEX_ENVIRONMENT_PLEX_CLAIM`
Add the missing `gluetun` variables and ports, set to the defaults listed in the gluetun wiki.
Remove whitespace on last line
Add missing end quote
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Remove `gluetun` variables for DNS https://github.com/qdm12/gluetun-wiki/blob/main/setup/options/dns.md
Remove `gluetun` variables for Healthcheck https://github.com/qdm12/gluetun-wiki/blob/main/setup/options/healthcheck.md
Remove `gluetun` variables to change the three listen addresses https://github.com/qdm12/gluetun-wiki/blob/main/setup/options/control-server.md `HTTP_CONTROL_SERVER_ADDRESS`=`:8000` https://github.com/qdm12/gluetun-wiki/blob/main/setup/options/http-proxy.md `HTTPPROXY_LISTENING_ADDRESS`=`:8888` https://github.com/qdm12/gluetun-wiki/blob/main/setup/options/shadowsocks.md `SHADOWSOCKS_LISTENING_ADDRESS`=`:8388`
Fix some incorrect and missing variables
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Signed-off-by: Eric Nemchik <eric@nemchik.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Purpose
<appname>_<section>_<varname>
where<section>
is new and mostly made up of eitherENVIRONMENT
orVOLUME
VOLUME
variables in scriptslogging
sections from all app templates (this simplifies the compose file and allows the user to configure a global default on their own or override individual apps easier)_
from appnamesRequirements
Check all boxes as they are completed