Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update RealtimeMessage for allRead/allSeen event #198

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sachaarbonel
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #198 (a1f685a) into master (90789df) will decrease coverage by 0.29%.
The diff coverage is 46.34%.

@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
- Coverage   76.94%   76.65%   -0.30%     
==========================================
  Files         139      141       +2     
  Lines        4646     4681      +35     
==========================================
+ Hits         3575     3588      +13     
- Misses       1071     1093      +22     
Impacted Files Coverage Δ
packages/faye_dart/lib/src/subscription.dart 76.92% <ø> (ø)
...es/stream_feed/lib/src/client/aggregated_feed.dart 94.28% <ø> (ø)
...ream_feed/lib/src/client/image_storage_client.dart 91.30% <ø> (ø)
...s/stream_feed/lib/src/client/reactions_client.dart 91.17% <ø> (ø)
...stream_feed/lib/src/client/stream_feed_client.dart 100.00% <ø> (ø)
...m_feed/lib/src/client/stream_feed_client_impl.dart 86.62% <ø> (ø)
...ckages/stream_feed/lib/src/core/api/batch_api.dart 1.49% <ø> (ø)
...es/stream_feed/lib/src/core/api/reactions_api.dart 96.82% <ø> (ø)
...eam_feed/lib/src/core/http/stream_http_client.dart 71.21% <ø> (ø)
...ages/stream_feed/lib/src/core/models/reaction.dart 97.22% <ø> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb2e051...a1f685a. Read the comment docs.

@followthemoney1
Copy link

@sachaarbonel is this resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification Feed Subscription not being triggered by ActivityMarker().allSeen().allRead()
2 participants