fix(design): Add back missing icon colors types

[darryltec]

Motivations

For some reason, rollup doesn't want to bring over the .css.d.ts file even tho we're referencing it. Could have something to do with the way those typed-css-module exports the type with the old-style imports export = styles.

Anyhoo, this makes rollup copy those files in the correct place. It now autocompletes again.

Prop table colors now shows the correct type

Changes

Added

• Added a plugin called rollup-plugin-copy to copy the missing .css.d.ts files over to dist so it gets exported

Changed

• Make rollup use the rollup-plugin-copy
• Update icon sizing type to use the existing type file rather than hard coding it
• Updated rollup-plugin-typescript2 to latest since it has issues/bug with async methods
  • Does not work with async plugins ezolenko/rollup-plugin-typescript2#105

Deprecated

Removed

Fixed

Security

Testing

Install the pre-release on the other repo and see that the colors now gets suggestions

npm i @jobber/design@0.24.1-pre.17+288721e0

---

In Atlantis we use Github's built in pull request reviews.

[cloudflare-pages]

Deploying with    Cloudflare Pages

Latest commit:	288721e
Status:	✅  Deploy successful!
Preview URL:	https://c9d464c4.atlantis.pages.dev

View logs

[timoteialbu]

This fixes Icon issues which is the AC of the story, but it would be nice to find the root cause of why rollup doesn't do this correctly, because if we do, then we can solve the other issues (for example Content has a prop spacing that also does not auto complete).

[darryltec]

Oh I think I know why. There was a pretty big change with the typed-css-modules format. https://github.com/GetJobber/atlantis/pull/677/files

I think it is related to how it gets exported. it was very different from that PR to what it is now

[darryltec]

@timoteialbu thanks for that thought. I have an idea on how to fix this. it's gonna be a hella big PR but it's gonna fix it!! 80% sure on that one.

[darryltec]

@timoteialbu that one is actually a lot harder to deal with as that issue goes back into v0 of atlantis.

This issue we're fixing is related but slightly different since it used to work. Why does it work? The history of the icon before the keyof typeof was it hardcoded all the colors.

I added another ticket to look at the bigger issue, but i think this should just go out as it's affecting atlantis, jobber online, and jobber mobile

[timoteialbu]

@timoteialbu that one is actually a lot harder to deal with as that issue goes back into v0 of atlantis.

This issue we're fixing is related but slightly different since it used to work. Why does it work? The history of the icon before the keyof typeof was it hardcoded all the colors.

I added another ticket to look at the bigger issue, but i think this should just go out as it's affecting atlantis, jobber online, and jobber mobile

If you made another ticket to look at it that sounds good to me!
I do wonder, would it be the worst to quickly add this copy stuff to all the other ones that are broken?

[darryltec]

@timoteialbu thought about it. it would basically add extra files that we don't need on the release. We'd have to figure out which one gets referenced as a keyof typeof and then copy it over.

[timoteialbu]

As discussed, we will have another ticket to try and fix the root cause so that we can fix the other type issues in the app. Good work on this!