Fixes for secret #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Superuser postgres will be created with password specified by environment variable POSTGRES_PASSWORD. By default postgres user can access without password password. Removed superuser privileges to torodb user. User torodb will be created with password specified by environment variable TORODB_PASSWORD. Default torodb user password is 'trustme'. Assign environment variable to empty value after starting ToroDB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found ~/.toropass file is not created anymore and it is necessary for ToroDB to start. This is different from ~/.pgpass that store the postgres superuser password and is removed after initialization.
Also I removed passwords from
Dockerfiles anddocker-compose.ymlbut specified the env variable key instead indocker-compose.ymlso the user can customize the password when starting up docker compose with:Or just start it without security configuration.
Too bad I can not find a better way to setup security for this docker compose but this seems to be an old feature request still not handled by docker.
Superuser postgres will be created with password specified by
environment variable POSTGRES_PASSWORD. By default postgres user can
login without any password.
Removed superuser privileges to torodb user.
User torodb will be created with password specified by environment
variable TORODB_PASSWORD. Default torodb user password is 'trustme'.
Assign environment variable to empty value after starting ToroDB.