New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component mounting/unmounting action #65
Comments
Having dialog is good. Provides flexibility and double check. I vote for toggle. No need to double the number of NFCs. The same NFC may also serve well as a swap action trigger for #66 |
Related to mounted and unmounted, is it worth considering having 'retired' as a separate, third state at the bottom of the list of components page? Having a list of retired components can be useful, as the user can reference back and compare the longevity of things. Separating retired and unmounted is also helpful as parts wear out and sometimes break and will never be used again. These are often replaced with brand new versions of the same component. The obviously example being the chain:
This is something the Strava's My Gear page has and would be nice to see in Bike Care. |
Also related is a useful feature I've seen elsewhere, which is a button to 'replace' a component when registering a service. This would carry out multiple actions for the user:
Quite a common occurrence with wear parts like chains, cassettes, brake pads, bearings etc. |
My idea is to rename the current 'active' toggle on a component to retired. This doesn't really do anything but we can separate components in that way. |
I get what you mean. But maybe a better place for this is at the 'to be retired' component right? Clicking that button will show popup with confirmation. And explanation what it will do. It will check the option 'retired' for the old component. and indeed copy all service schedules (not logs) to a new component with the same name and type. I'm only thinking, should we directly be able to set the new installation date? Or just click replace and you will be directed to the new part where you can enter the mounted date later? |
Hmm, both would be fine I think, but I'd go for the second option as I can imagine circumstances where the user might not know when a replacement was being installed (maybe waiting for a replacement part in the post?) |
While working on #64 I will also work on this one since I now know whether a component is mounted or not in my frontend code. The idea is to show this for unmounted components: Clicking the button will then open a dialog to enter the date of when it was mounted or unmounted. |
Also made the unmounting working now. I think it works great. I will do some cleaning up on the code and then hope to deploy it somewhere today or later this week. Edit: Let me know what you think! It's deployed now. |
Had a quick play around and looks to be working well so far! 👏 |
Is your feature request related to a problem? Please describe.
Currently, if I want to swap components on the same bike I need to edit components' usage time periods.
Describe the solution you'd like
I want a button for every component, that says Unmount for a mounted component and Mount for a non-mounted component and clicking the button would do the relevant and required magic on BE.
Ideally, it wouldn't be possible to have 2+ components of the same type (assuming right and left pedals, from and rear wheels are different types) be mounted at the same time, i.e. only one component of a type can be Unmounted, and any components are not mountable if at least 1 component of the same type is mounted. Altho when no component of a specific type is mounted yet, any of other components would be mountable.
Please allow NFC/QR for the action (same NFC/QR to unmount if the component is mounted, and mount if it is unmounted).
Describe alternatives you've considered
Editing components' usage time periods and making sure they do not overlap.
Additional context
n/a
The text was updated successfully, but these errors were encountered: