Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active/Inactive vs Mounted/Unmounted vs Usable/Retired component #64

Closed
OleksiyRudenko opened this issue Mar 25, 2024 · 7 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@OleksiyRudenko
Copy link

Is your feature request related to a problem? Please describe.
A component's Active property sounds ambiguous.
It would be great to have more explicit and specific properties names.
E.g. Mounted (meaning it is mounted on a bike), Retired (if a component is decomissioned and no longer would be mounted or serviced, kept on record for history backtracking purposes and for data consistency reasons).

Describe the solution you'd like
Change component property names to more specific.

Describe alternatives you've considered
Remembering the property meaning and deducing it by changing the value and figure the consequences out.

@OleksiyRudenko OleksiyRudenko changed the title Active/Inactive vs Mounted/Unmounted component Active/Inactive vs Mounted/Unmounted vs Usable/Retired component Mar 25, 2024
@Gerben321 Gerben321 added the enhancement New feature or request label Mar 25, 2024
@Gerben321 Gerben321 self-assigned this Mar 25, 2024
@Gerben321
Copy link
Owner

Gerben321 commented Mar 25, 2024

Yeah, like we discussed this is a good idea. What would be the best terms?

When a component is still good to use, but is installed on your bike, or not:

  • Mounted/Not mounted or Unmounted
  • Installed/Not installed or Uninstalled
  • Active/Not active or Inactive

And when a component is no longer used, and will not be used anymore (broken, worn, etc):

  • Decommissioned
  • Retired

@Konstantin-Levin Could you also help us think about this? This might be useful for you as well, since you're using a lot more bikes and components then we are, I think. 😎

@OleksiyRudenko
Copy link
Author

OleksiyRudenko commented Mar 25, 2024

Thank you for looking into this.
I have also added a couple more feature requests to deal with mounting and swapping components.

My rationale behind the term "Retired" was Strava's term. If BikeCare used the same term users will have proper mental connection between actions in Strava and in BikeCare.

Screenshot from Strava:
image

@Gerben321
Copy link
Owner

I agree with that. That would sound good to keep the same term. And the placement in your screenshot also sounds good.

@Konstantin-Levin
Copy link

I agree with all of the above regarding the wording. I think each component could fall into 1 of 3 states.

  1. Mounted
  2. Unmounted
  3. Retired

I've got a few other ideas about retiring components. I'll put them in #65 as it seems the better place

@Gerben321
Copy link
Owner

I've just deployed a new version which got rid of the active toggle. It has changed to retired, which is off by default.

The rest is still the same, just changed same naming. Next up will be the mounted or not mounted display.

@Gerben321
Copy link
Owner

Here's a simple example of how it will look like:
image
The last install period is fetched, and the frontend will 'calculate' whether it's installed or not. It will then put it in the correct list and show it. I think I will also add a filter for this.

@Gerben321
Copy link
Owner

This is also deployed now. Let me know what you think 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants