Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiment(mediaviewer): clapper support #931

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

GeopJr
Copy link
Owner

@GeopJr GeopJr commented Apr 30, 2024

Mostly experimenting

  • Flatpak manifest partially copied from https://github.com/Rafostar/clapper-vala-test/
  • Meson will detect if clapper is installed and enable clapper support, otherwise Gtk.Video will be used
  • I noticed that when dismissing the MV, Tuba freezes with gdk_gl_context_make_current() failed, I probably omitted something

Overall Clapper is awesome! Streaming just works and it comes with many features!

Obviously, this is just an initial implementation, everything will get ironed out as we move forward with this (like saving volume > 1, fullscreen etc...)

Screencast.from.2024-04-30.05-31-40.webm

cc: @Rafostar

Co-authored-by: Rafał Dzięgiel <rafostar.github@gmail.com>
@Rafostar
Copy link

Rafostar commented May 1, 2024

I did not expect a draft PR so soon, surprise. Also, I see that I am for some reason co-authoring this... but I didn't do anything yet 😅

Flatpak manifest partially copied from https://github.com/Rafostar/clapper-vala-test/

I have updated the Clapper Vala test recently. It now simply builds latest GStreamer version without any patches. I also removed some extra flatpak permissions from it.

I mainly used that repo for testing Vala bindings (and Clapper GI bindings overall) during development (which took a while). At that time GStreamer 1.24 did not exist yet, so I was working around my issues with patches, now that most of stuff I needed is upstreamed or fixed there and 1.24 exists now, there is no need for them anymore.

Due to above, I kindly ask you to not spread these patches further. If you are going to build GStreamer anyway, just use latest version with all fixes/benefits from it without patching stuff please. Its my fault for not doing that before tagging a release of Clapper, sorry.

@Rafostar
Copy link

Rafostar commented May 5, 2024

Hey, thanks for the update 👍

I noticed that when dismissing the MV, Tuba freezes with gdk_gl_context_make_current() failed, I probably omitted something

I gave it a quick go, and this doesn't happen to me anymore after latest rebuild.

Obviously, this is just an initial implementation, everything will get ironed out as we move forward with this (like saving volume > 1, fullscreen etc...)

Yes, there is now UI look/logic to figure out left. Next runtime (Freedesktop SDK used for GNOME 47) will have GStreamer 1.24 so you will not have to build it. I started some work on download cache that you suggested would also be nice to have and will probably continue/finish it anyway since it might be useful for other apps too regardless if this PR will continue or get scrapped.

Now its entirely up to you whether you want to continue with this or not (and its totally fine if you do not 😄). Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants