Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(network): remove header on insecure requests #304

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GeopJr
Copy link
Owner

@GeopJr GeopJr commented Jun 8, 2023

if a request is known to be 100% out of instance or doesn't need auth then setting is_insecure should strip any auth headers even if with_account is explicitly set

note: with_account has two use cases:

  1. if host is missing from the url it uses the account's instance
  2. set auth headers with the account's token

is_insecure will strip the auth headers

maybe should be renamed to with_auth and do the opposite?

if a request is known to be 100% out of instance or doesn't need auth then setting is_insecure should strip any auth headers even if with_account is explicitly set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant