Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue 3 #743

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Vue 3 #743

wants to merge 1 commit into from

Conversation

BilelJegham
Copy link
Member

@BilelJegham BilelJegham commented Apr 12, 2024

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description

Since Vue2 EOL, GeoGuess might to migrate to Vue3.

This PR follow the evolution of this subject.
Contributor can publish PR to the #next branch

* Doesn't load past home page

* Loads slightly more on home page

* Loads a bit more, buttons don't work

* Working

* Refactor imports

* Fully working

* Removed Jest as it is not Vite compatible

* Update src/lang/index.js

Co-authored-by: Bilel Jegham <BilelJegham@users.noreply.github.com>

* Reverse trailing commas and version number

* Everything but Cypress is working

* Merge branch 'master' of https://github.com/GeoGuess/GeoGuess into GeoGuess-master

* Fix eslint

* Update package.json

Co-authored-by: Bilel Jegham <BilelJegham@users.noreply.github.com>

* Update package.json

Co-authored-by: Bilel Jegham <BilelJegham@users.noreply.github.com>

* Vitest not working yet

* Vitest working a bit more

* Patched jest-google-maps-mock

* Update vite.config.js

* Vitest almost working

* Fixed stryker

* Add @ imports back

* Forgot some

* Update CardRoomMap.spec.js

* Update /store/index.js

* Merge

* fix: package

* fix: lint

* fix: add coverage test

* Fix patch package failure

* Fix ESLint with Vitest

* Update snapshot?

---------

Co-authored-by: Bilel Jegham <BilelJegham@users.noreply.github.com>
Co-authored-by: BilelJegham <contact.bileljegham@gmail.com>
Copy link

sonarcloud bot commented Apr 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

cypress bot commented Apr 12, 2024

3 failed tests on run #712 ↗︎

3 4 0 0 Flakiness 0

Details:

Vue 3
Project: GeoGuess Commit: 311395a4cb
Status: Failed Duration: 01:58 💡
Started: Apr 12, 2024 8:24 PM Ended: Apr 12, 2024 8:26 PM
Failed  gameSingleCountry.test.js • 1 failed test • chrome

View Output

Test Artifacts
SinglePlayer > Play SinglePlayer Mode Country Time 10s Test Replay Screenshots
Failed  multi.test.js • 2 failed tests • chrome

View Output

Test Artifacts
Multiplayer > Create Multiplayer Test Replay Screenshots
Multiplayer > Join Multiplayer Test Replay Screenshots

Review all test suite changes for PR #743 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants