Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: add Root Access documentation page for Desktop #7

Merged
merged 1 commit into from
May 24, 2024

Conversation

c-quenin
Copy link
Contributor

@c-quenin c-quenin commented Apr 17, 2024

Unrooted devices are now supported on some Desktop versions.
Add the corresponding documentation pages.

JIRA: SYSTEM-1779 and SYSTEM-2475

@c-quenin
Copy link
Contributor Author

Added the DO NOT MERGE tag because we need to wait for the documentation to be released before merging this.

Copy link

@jmaneyrol69 jmaneyrol69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just to let you know, @c-quenin , the doc PRs will be merged when the feature/product is released. I hope this won't delay the release?

Unrooted devices are now supported on some Desktop versions.
Add the corresponding documentation page.
@c-quenin c-quenin force-pushed the SYSTEM-1779/unrooted-for-all-products branch from 07552b3 to e681b8d Compare May 23, 2024 15:23
@c-quenin c-quenin changed the title README: add Root Access documentation page for Desktop and SaaS README: add Root Access documentation page for Desktop May 23, 2024
@c-quenin
Copy link
Contributor Author

c-quenin commented May 23, 2024

Removing the DONOTMERGE tag as Desktop 3.7.0 has been released.
I've also removed the SaaS doc addition in another PR #8 so that we can merge this one for Desktop and wait for the next SaaS release

Copy link

@jmaneyrol69 jmaneyrol69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c-quenin c-quenin merged commit 0733239 into master May 24, 2024
@c-quenin c-quenin deleted the SYSTEM-1779/unrooted-for-all-products branch May 24, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants