Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Set PROJ_LIB in the Benchmarks workflow to fix the proj_create_from_database error #3241

Merged
merged 3 commits into from May 12, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented May 11, 2024

Description of proposed changes

In the "Benchmarks" workflow (e.g., https://github.com/GenericMappingTools/pygmt/actions/runs/9001470390/job/24727777928), we can see an error like:

  ERROR 1: PROJ: proj_create_from_database: Open of /usr/share/miniconda/share/proj failed

which is not seen in the Tests workflow (e.g., https://github.com/GenericMappingTools/pygmt/actions/runs/9039830454/job/24843235152).

Currently, the "Benchmarks" workflow is not affected by the error and still passes, but it fails in #3193. So, we should fix the error.

It's unclear what's happening exactly, but the solution is simple. We just need to set the PROJ_LIB environment variable. xref: https://gis.stackexchange.com/questions/364421/how-to-make-proj-work-via-anaconda-in-google-colab/370360#370360

After this patch, the error disappears. See https://github.com/GenericMappingTools/pygmt/actions/runs/9039893228/job/24843381919

@seisman seisman added run/benchmark Trigger the benchmark workflow in PRs maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog needs review This PR has higher priority and needs review. labels May 11, 2024
@seisman seisman added this to the 0.13.0 milestone May 11, 2024
@seisman seisman requested a review from weiji14 May 11, 2024 08:30
Copy link

codspeed-hq bot commented May 12, 2024

CodSpeed Performance Report

Merging #3241 will degrade performances by 11.31%

Comparing ci/benchmarks-proj (7e5b7da) with main (4fbf32f)

Summary

❌ 1 regressions
✅ 98 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main ci/benchmarks-proj Change
test_grdsample_dataarray_out 48.7 ms 54.9 ms -11.31%

@seisman seisman merged commit 9d0c02e into main May 12, 2024
6 of 7 checks passed
@seisman seisman deleted the ci/benchmarks-proj branch May 12, 2024 23:17
@seisman seisman removed needs review This PR has higher priority and needs review. run/benchmark Trigger the benchmark workflow in PRs labels May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant