WIP: Wrap GMT's standard data type GMT_IMAGE for images #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Minimal xarray.DataArray output with data and coordinates, no metadata yet.
seisman
commented
Mar 20, 2024
| }[kind] | ||
| with self.open_virtualfile(family, geometry, "GMT_OUT", None) as vfile: | ||
| with self.open_virtualfile( | ||
| family, geometry, "GMT_OUT|GMT_IS_REFERENCE", None |
There was a problem hiding this comment.
For unknown reasons (likely upstream bug), using GMT_OUT crashes and GMT_OUT|GMT_IS_REFERENCE works for image. So better to use GMT_OUT for dataset/grid and GMT_OUT|GMT_IS_REFERENCE for image.
We also need to open an upstream issue and find out why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #2398 but for images.