Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert when asset does not have decimals #95

Merged

Conversation

trmid
Copy link
Member

@trmid trmid commented Mar 22, 2024

This is to ensure a consistent UX. Assets without decimals() are very rare, and there are varying standards for what the default decimals should be (some apps fallback to 0, some fallback to 18), so if someone wants to deploy a new PrizeVault with an asset that has no specified decimals, they should create a custom deployment that uses the most applicable decimal value for the asset.

Copy link

linear bot commented Mar 22, 2024

Copy link

LCOV of commit 3556d22 during coverage #510

Summary coverage rate:
  lines......: 99.5% (208 of 209 lines)
  functions..: 100.0% (55 of 55 functions)
  branches...: no data found

Files changed coverage rate:
                              |Lines       |Functions  |Branches    
  Filename                    |Rate     Num|Rate    Num|Rate     Num
  ==================================================================
  src/PrizeVault.sol          |99.4%    179| 100%    44|    -      0

@trmid trmid merged commit f262082 into main Mar 22, 2024
2 checks passed
@trmid trmid deleted the gen-1223-m-172-assets-without-decimals-can-cause-ux-issues branch March 22, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants