New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account for yieldFeeBalance in twabSupplyLimit #93
Merged
trmid
merged 4 commits into
main
from
gen-1231-m-91m-244-twab-supply-limit-should-account-for-unrealized
Mar 22, 2024
Merged
Account for yieldFeeBalance in twabSupplyLimit #93
trmid
merged 4 commits into
main
from
gen-1231-m-91m-244-twab-supply-limit-should-account-for-unrealized
Mar 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCOV of commit
|
asselstine
requested changes
Mar 20, 2024
asselstine
requested changes
Mar 22, 2024
LCOV of commit
|
trmid
deleted the
gen-1231-m-91m-244-twab-supply-limit-should-account-for-unrealized
branch
March 22, 2024 21:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TWAB supply limit is expected to never be reached in a prize vault, but if a deployer makes a mistake or if the underlying asset has a highly fluctuating total supply, it's possible that it can be. In this case, the accrued yield fee balance must be protected so that the yield fee funds can't be locked in by depositors.
These changes ensure that the yield fee balance is always accounted for in the TWAB total supply limit and ensures that no new mints, deposits or liquidations can occur if they will exceed this limit.