Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated claimer comment #88

Merged
merged 1 commit into from Mar 18, 2024
Merged

Remove outdated claimer comment #88

merged 1 commit into from Mar 18, 2024

Conversation

trmid
Copy link
Member

@trmid trmid commented Mar 18, 2024 •
edited

The claimer contract is one to many so there's no reason for it to be the zero address on deployment.

@linear Linear
Copy link

linear bot commented Mar 18, 2024

GEN-1225 [QA-36] Remove Claimer Zero Address Comment

@trmid trmid mentioned this pull request Mar 18, 2024
Closed
@github-actions GitHub Actions
Copy link

LCOV of commit 3d6d51f during coverage #486

Summary coverage rate:
  lines......: 99.0% (202 of 204 lines)
  functions..: 100.0% (55 of 55 functions)
  branches...: no data found

Files changed coverage rate:
                              |Lines       |Functions  |Branches    
  Filename                    |Rate     Num|Rate    Num|Rate     Num
  ==================================================================
  src/PrizeVaultFactory.sol   | 100%      7| 100%     2|    -      0

@trmid trmid merged commit 3e9e2b9 into main Mar 18, 2024
2 checks passed
@trmid trmid deleted the gen-1225-qa-36-remove-claimer-zero-address-comment branch March 18, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asselstine asselstine asselstine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trmid @asselstine