Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subtract only the amount of shares claimed from the yield fee balance #85

Merged
merged 1 commit into from Mar 18, 2024
Merged

subtract only the amount of shares claimed from the yield fee balance #85

merged 1 commit into from Mar 18, 2024

Conversation

trmid
Copy link
Member

@trmid trmid commented Mar 14, 2024

The yield fee balance was being completely wiped regardless of the amount of shares being claimed. Instead, it should only subtract the amount of shares claimed.

@linear Linear
Copy link

linear bot commented Mar 14, 2024

GEN-1220 [H-59] yield fee balance share subtraction bug

@github-actions GitHub Actions
Copy link

LCOV of commit 582f5b8 during coverage #480

Summary coverage rate:
  lines......: 99.0% (201 of 203 lines)
  functions..: 100.0% (55 of 55 functions)
  branches...: no data found

Files changed coverage rate:
                              |Lines       |Functions  |Branches    
  Filename                    |Rate     Num|Rate    Num|Rate     Num
  ==================================================================
  src/PrizeVault.sol          |98.8%    173| 100%    44|    -      0

@trmid trmid mentioned this pull request Mar 14, 2024
Open
asselstine
asselstine approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@asselstine asselstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Surprised we missed that

@trmid trmid merged commit cc9e119 into main Mar 18, 2024
2 checks passed
@trmid trmid deleted the gen-1220-h-59-yield-fee-balance-share-subtraction-bug branch March 18, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asselstine asselstine asselstine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trmid @asselstine