Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug in last observation timestamp #31

Merged
merged 2 commits into from Mar 22, 2024
Merged

Fixed bug in last observation timestamp #31

merged 2 commits into from Mar 22, 2024

Conversation

asselstine
Copy link
Contributor

No description provided.

@linear Linear
Copy link

linear bot commented Mar 21, 2024

GEN-1136 Double check that TwabController lastObservationAt is accurate

@github-actions GitHub Actions
Copy link

LCOV of commit 725cc15 during 100% Test Coverage #167

Summary coverage rate:
  lines......: 100.0% (242 of 242 lines)
  functions..: 100.0% (57 of 57 functions)
  branches...: no data found

Files changed coverage rate:
                                  |Lines       |Functions  |Branches    
  Filename                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================
  src/TwabController.sol          | 100%    117| 100%    35|    -      0
  src/libraries/TwabLib.sol       | 100%    110| 100%    21|    -      0

trmid
trmid requested changes Mar 22, 2024
View reviewed changes
src/libraries/TwabLib.sol Outdated
Comment on lines 255 to 258
console2.log("lastObservationAt", lastObservationAt(PERIOD_LENGTH, PERIOD_OFFSET));
// if this is for an overflowed time period, return 0
if (isShutdownAt(_targetTime, PERIOD_OFFSET)) {
if (isShutdownAt(_targetTime, PERIOD_LENGTH, PERIOD_OFFSET)) {
console2.log("IS SHUTDOWN", _targetTime);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove console logs

src/libraries/TwabLib.sol Outdated
@@ -1,6 +1,8 @@
// SPDX-License-Identifier: MIT
pragma solidity ^0.8.19;

import "forge-std/console2.sol";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove console log import

@asselstine asselstine merged commit 817ca2d into main Mar 22, 2024
2 checks passed
@asselstine asselstine deleted the gen-1136-double-check-that-twabcontroller-lastobservationat-is branch March 22, 2024 23:48
@github-actions GitHub Actions
Copy link

LCOV of commit ffc19c3 during 100% Test Coverage #169

Summary coverage rate:
  lines......: 100.0% (240 of 240 lines)
  functions..: 100.0% (57 of 57 functions)
  branches...: no data found

Files changed coverage rate:
                                  |Lines       |Functions  |Branches    
  Filename                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================
  src/TwabController.sol          | 100%    117| 100%    35|    -      0
  src/libraries/TwabLib.sol       | 100%    108| 100%    21|    -      0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trmid trmid trmid requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asselstine @trmid