Refactored a variable name and some tests #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCOV of commit
|
trmid
requested changes
Mar 22, 2024
Comment on lines
+1723
to
+1759
| // function mockGetAverageBalanceBetween( | ||
| // address _vault, | ||
| // address _user, | ||
| // uint48 _startTime, | ||
| // uint48 _endTime, | ||
| // uint256 _result | ||
| // ) internal { | ||
| // vm.mockCall( | ||
| // address(twabController), | ||
| // abi.encodeWithSelector( | ||
| // TwabController.getTwabBetween.selector, | ||
| // _vault, | ||
| // _user, | ||
| // _startTime, | ||
| // _endTime | ||
| // ), | ||
| // abi.encode(_result) | ||
| // ); | ||
| // } | ||
|
|
||
| // function mockGetAverageTotalSupplyBetween( | ||
| // address _vault, | ||
| // uint32 _startTime, | ||
| // uint32 _endTime, | ||
| // uint256 _result | ||
| // ) internal { | ||
| // vm.mockCall( | ||
| // address(twabController), | ||
| // abi.encodeWithSelector( | ||
| // TwabController.getTotalSupplyTwabBetween.selector, | ||
| // _vault, | ||
| // _startTime, | ||
| // _endTime | ||
| // ), | ||
| // abi.encode(_result) | ||
| // ); | ||
| // } |
There was a problem hiding this comment.
could remove if we don't need these anymore
test/PrizePool.t.sol
Outdated
Comment on lines
1841
to
1877
| // function mockGetAverageBalanceBetween( | ||
| // address _vault, | ||
| // address _user, | ||
| // uint48 _startTime, | ||
| // uint48 _endTime, | ||
| // uint256 _result | ||
| // ) internal { | ||
| // vm.mockCall( | ||
| // address(twabController), | ||
| // abi.encodeWithSelector( | ||
| // TwabController.getTwabBetween.selector, | ||
| // _vault, | ||
| // _user, | ||
| // _startTime, | ||
| // _endTime | ||
| // ), | ||
| // abi.encode(_result) | ||
| // ); | ||
| // } | ||
|
|
||
| // function mockGetAverageTotalSupplyBetween( | ||
| // address _vault, | ||
| // uint32 _startTime, | ||
| // uint32 _endTime, | ||
| // uint256 _result | ||
| // ) internal { | ||
| // vm.mockCall( | ||
| // address(twabController), | ||
| // abi.encodeWithSelector( | ||
| // TwabController.getTotalSupplyTwabBetween.selector, | ||
| // _vault, | ||
| // _startTime, | ||
| // _endTime | ||
| // ), | ||
| // abi.encode(_result) | ||
| // ); | ||
| // } |
There was a problem hiding this comment.
could remove if we don't need these anymore
LCOV of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.