Updated DrawManager events to include reward #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCOV of commit
|
trmid
requested changes
Mar 21, 2024
Comment on lines
121
to
128
| event DrawStarted( | ||
| address indexed sender, | ||
| address indexed recipient, | ||
| uint24 drawId, | ||
| uint32 rngRequestId, | ||
| uint48 elapsedTime | ||
| uint24 indexed drawId, | ||
| uint48 elapsedTime, | ||
| uint reward, | ||
| uint32 rngRequestId | ||
| ); |
src/DrawManager.sol
Outdated
Comment on lines
130
to
141
| /// @notice Emitted when the finish draw is called | ||
| /// @param drawId The draw id | ||
| /// @param elapsedTime The amount of time that had elapsed between start draw and finish draw | ||
| /// @param startRecipient The recipient of the start rng auction reward | ||
| /// @param startReward The reward for the start rng auction | ||
| /// @param finishRecipient The recipient of the finish draw auction reward | ||
| /// @param finishReward The reward for the finish draw auction | ||
| /// @param recipient The recipient of the finish draw auction reward | ||
| /// @param reward The reward for the finish draw auction | ||
| /// @param remainingReserve The remaining reserve after the rewards have been allocated | ||
| event DrawFinished( | ||
| address indexed sender, | ||
| address indexed recipient, | ||
| uint24 indexed drawId, | ||
| uint elapsedTime, | ||
| address indexed startRecipient, | ||
| uint startReward, | ||
| address indexed finishRecipient, | ||
| uint finishReward, | ||
| uint48 elapsedTime, | ||
| uint reward, |
LCOV of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.