Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten dynamic claim fee range #31

Merged

Conversation

trmid
Copy link
Member

@trmid trmid commented Apr 9, 2024

  • previous range was [canary 1, GP * % max fee]
  • new range is [canary 2, full daily prize value]

This brings the starting price slightly down (prevents the auction from starting above the market rate) and lets it reach the expected market rate slightly slower than before (more of the auction time is needed before the market price is reached).

@trmid trmid requested a review from asselstine April 9, 2024 21:52
Copy link

linear bot commented Apr 9, 2024

Copy link

github-actions bot commented Apr 9, 2024

LCOV of commit 1d77755 during Tests with 100% Coverage #147

Summary coverage rate:
  lines......: 100.0% (82 of 82 lines)
  functions..: 100.0% (17 of 17 functions)
  branches...: no data found

Files changed coverage rate:
                                  |Lines       |Functions  |Branches    
  Filename                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================
  src/Claimer.sol                 | 100%     51| 100%    11|    -      0

@trmid trmid merged commit 1d277ab into main Apr 10, 2024
2 checks passed
@trmid trmid deleted the gen-1289-update-claimer-to-use-daily-prize-tier-as-max-fee-param branch April 10, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant