Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove already claimed check to match prize pool changes #28

Merged
merged 2 commits into from Mar 21, 2024

Conversation

trmid
Copy link
Member

@trmid trmid commented Mar 21, 2024

The prize pool is now set to revert if a prize has already been claimed, this means that the claimer already catches these with the ClaimError event and no special treatment is needed.

Copy link

linear bot commented Mar 21, 2024

Copy link

LCOV of commit 823eb79 during Tests with 100% Coverage #134

Summary coverage rate:
  lines......: 100.0% (76 of 76 lines)
  functions..: 100.0% (15 of 15 functions)
  branches...: no data found

Files changed coverage rate:
                                  |Lines       |Functions  |Branches    
  Filename                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================
  src/Claimer.sol                 | 100%     45| 100%     9|    -      0

@trmid trmid merged commit 89baf8a into main Mar 21, 2024
2 checks passed
@trmid trmid deleted the gen-1233-m-345-prize-claim-reentrancy branch March 21, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants