Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw window only when both LCDC.0 and LCDC.5 are enabled #164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhysd
Copy link

@rhysd rhysd commented Dec 6, 2021

Window should be rendered only when LCDC.0 and LCDC.5 are enabled. But mooneye-gb checks only LCDC.5. This PR fixes the point.

PanDocs: https://gbdev.io/pandocs/LCDC.html#ff40---lcdc-lcd-control-rw

@rhysd
Copy link
Author

rhysd commented Dec 6, 2021

The diff may look a bit complicated, but actually this PR simply moves the if clause for rendering window into the if clause for rendering background so that the window can be rendered only when the background is rendered. (Please check 'Hide whitespace' diff setting in the review page)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant