Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing the key prop for ThreeDotsIcon #5680

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

msyaifullah
Copy link

@msyaifullah msyaifullah commented Feb 18, 2023

issues ref: #4429 (comment)

Summary

when i use <ThreeDotsIcon size="3" mt="0.5" color="white" /> components i'm facing an error coming from this component

ERROR  Warning: Each child in a list should have a unique "key" prop.

Check the render method of `ForwardRef(createdIcon)`. See https://reactjs.org/link/warning-keys for more information.
G@http://192.168.1.68:19000/node_modules/expo/AppEntry.bundle?platform=ios&dev=true&hot=false:161941:36
    in createdIcon
    in RCTView (created by View)
    in View
    in Unknown
    in Box
    in Center
    in RCTView (created by View)
    in View
    in Unknown
    in Box
    in RCTView (created by View)
    in View
    in Unknown
    in Box
    in Stack
    in HStack
    in RCTView (created by View)
    in View
    in Unknown
    in Box
    in RCTView (created by View)
    in View (created by Pressable)
    in Pressable (created by Pressable)
    in Unknown
    in Pressable
    in RCTView (created by View)
    in View
    in Unknown
    in Box
    in ExampleOne (created by TabTwoScreen)
    in RCTView (created by View)

it's happen because <G> is i loop under path properties and it's required to add props key since it's single i believe change to single object is enough.

Changelog

[General][Fixed] - Fix missing key prop for ThreeDotsIcon component by change from array <G> component to single Object <G> component for ThreeDotsIcon

Test Plan

Screen Shot 2023-02-18 at 23 46 00

before

Screen Shot 2023-02-18 at 23 42 11

after

@vercel
Copy link

vercel bot commented Feb 18, 2023

@msyaifullah is attempting to deploy a commit to the Geekyants Team Team on Vercel.

A member of the Team first needs to authorize it.

@auto-assign auto-assign bot requested a review from rayan1810 February 18, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant