Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Installing multiple mods for same/different server type #4450

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

un-boxing-man
Copy link
Contributor

@un-boxing-man un-boxing-man commented Jan 20, 2024

Description

Changed modsinstalledlist in mods_core from installed-mods.txt to ${selfname}-installed-mods.txt
added selfname to allow multiple instances of the same game running different mods and different games to have mods

*more detail on the why in issue #4451

Fixes #4451

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue. soon!
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Changed modsinstalledlist to allow mutable instances running different mods
@dgibbs64
Copy link
Member

dgibbs64 commented Jan 21, 2024

If multiple servers instances are sharing the same serverfiles then they both will have the same mods installed as they are using the same files. If you want different mods then you need to install multiple installations
https://docs.linuxgsm.com/configuration/multiple-game-servers

I think you are mis-understanding now instances and installations work

@un-boxing-man
Copy link
Contributor Author

If multiple servers instances are sharing the same serverfiles then they both will have the same mods installed as they are using the same files. If you want different mods then you need to install multiple installations https://docs.linuxgsm.com/configuration/multiple-game-servers

I think you are mis-understanding now instances and installations work

Each instance has its own server files folder and script The only issue is installing different types of mods on different servers same game

Here's how my file structure is

├── rustserverfiles
│ ├── oxide
│ ├── rustDedicated_data
├── rustserverfiles2
│ ├── oxide
│ ├── rustDedicated_data
├── l4d2serverfiles
│ ├── Left4dead2
│ ├── adons
├── lsgm
│ ├── config-lsgm
│ ├── mods
├── linuxgsm.sh
├── Rustserver-2
└── L4d2server

The problem is the server instance is stayed completely separate except for when checking for mods and updating mods
When updateing L4d2 mods the mods for the rust servers ended up in that server files
And that is what this fixes it makes the installed mods text per server instance so they don't get mixed up

If this option for fixing it is not liked i can always change it to check if those mods are available for that server every time or somehow label in the one file what mods are installed for that instance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants