Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(newserver): add FabricMC Server #3475

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

feat(newserver): add FabricMC Server #3475

wants to merge 10 commits into from

Conversation

Ceddicedced
Copy link

@Ceddicedced Ceddicedced commented Jun 7, 2021 •
edited

Description

Fabric is a modular modding toolchain targeting Minecraft 1.14 and above, including snapshots.

I took #3292 as an example.

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@johnoclockdk johnoclockdk self-requested a review October 17, 2021 21:53
@h3o66 h3o66 added the branch conflicts Branch of pr has conflicts that need to be worked on label Dec 10, 2021
@h3o66
Copy link
Member

h3o66 commented Dec 10, 2021

Would it be possible for you to rebase this branch on the latest release ?

h3o66
h3o66 requested changes Dec 10, 2021
View reviewed changes
lgsm/functions/update_fabricmc.sh Outdated Show resolved Hide resolved
lgsm/functions/update_fabricmc.sh Outdated Show resolved Hide resolved
lgsm/functions/check_deps.sh Outdated Show resolved Hide resolved
lgsm/functions/check_deps.sh Outdated Show resolved Hide resolved
@Ceddicedced
Copy link
Author

I will look into this. Thanks for your feedback

Ceddicedced
Ceddicedced commented Dec 15, 2021
View reviewed changes
Copy link
Author

@Ceddicedced Ceddicedced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've now checked all your comments and updated my changes to the latest version of the develop branch

h3o66
h3o66 requested changes Dec 15, 2021
View reviewed changes
lgsm/functions/update_fabricmc.sh Outdated Show resolved Hide resolved
lgsm/functions/update_fabricmc.sh Show resolved Hide resolved
@h3o66
Copy link
Member

h3o66 commented Dec 15, 2021

I've now checked all your comments and updated my changes to the latest version of the develop branch

looks better, but only 2 litte changes are needed

Ceddicedced
Ceddicedced commented Dec 15, 2021
View reviewed changes
Copy link
Author

@Ceddicedced Ceddicedced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now intends should be all the same. And the last empty lines are now also deleted

johnoclockdk
johnoclockdk approved these changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@johnoclockdk johnoclockdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seem to be fine now

@h3o66 h3o66 added type: game server request Request for a new server and removed branch conflicts Branch of pr has conflicts that need to be worked on labels Dec 17, 2021
@Jerry1098
Copy link

Is there any update on this and is this going to be merged soon?

@h3o66 h3o66 requested a review from dgibbs64 August 23, 2022 15:05
@h3o66 h3o66 added the branch conflicts Branch of pr has conflicts that need to be worked on label Aug 24, 2022
h3o66
h3o66 requested changes Aug 24, 2022
View reviewed changes
Copy link
Member

@h3o66 h3o66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this PR once more

@dgibbs64 dgibbs64 force-pushed the develop branch 3 times, most recently from 09d0a88 to f0892d9 Compare October 21, 2022 23:38
@dgibbs64 dgibbs64 force-pushed the develop branch 3 times, most recently from bfcdc3a to e5402d4 Compare October 29, 2022 11:15
@meguroyama
Copy link

Hi, I'm interested in this merge soon. Is it stalled ?

@dgibbs64 dgibbs64 force-pushed the develop branch 5 times, most recently from 891ed8f to ca184e3 Compare September 7, 2023 20:23
@dgibbs64 dgibbs64 force-pushed the develop branch 2 times, most recently from 7a72c04 to f28a4e5 Compare December 3, 2023 00:09
@whytf
Copy link

whytf commented Apr 2, 2024

Hi, I'm interested in this merge soon. Is it stalled ?

I'm interested as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h3o66 h3o66 h3o66 requested changes

@johnoclockdk johnoclockdk johnoclockdk approved these changes

@dgibbs64 dgibbs64 Awaiting requested review from dgibbs64

Assignees
No one assigned
Labels
branch conflicts Branch of pr has conflicts that need to be worked on type: game server request Request for a new server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Ceddicedced @h3o66 @Jerry1098 @meguroyama @whytf @johnoclockdk